Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1681958] Use eReplacedSizing to assert replaced elements for aspect-ratio. #29354

Merged
merged 1 commit into from Jun 13, 2021

Conversation

moz-wptsync-bot
Copy link
Collaborator

@moz-wptsync-bot moz-wptsync-bot commented Jun 12, 2021

It seems eReplacedSizing is much closer to the definition of replaced
elements (defined in [1]), and we override ComputeSize() for those
frames which are set eReplacedSizing or inline/table frames.

Perhaps we have to update the comments for the frame type bits later.

[1] https://html.spec.whatwg.org/multipage/rendering.html#replaced-elements

Differential Revision: https://phabricator.services.mozilla.com/D117372

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1681958
gecko-commit: 738bc12bd497cbb828435bbf761c5820c5cb8ffc
gecko-reviewers: TYLin

It seems `eReplacedSizing` is much closer to the definition of replaced
elements (defined in [1]), and we override ComputeSize() for those
frames which are set eReplacedSizing or inline/table frames.

Perhaps we have to update the comments for the frame type bits later.

[1] https://html.spec.whatwg.org/multipage/rendering.html#replaced-elements

Differential Revision: https://phabricator.services.mozilla.com/D117372

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1681958
gecko-commit: 738bc12bd497cbb828435bbf761c5820c5cb8ffc
gecko-reviewers: TYLin
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

@moz-wptsync-bot moz-wptsync-bot merged commit 4a32510 into master Jun 13, 2021
20 checks passed
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1681958 branch Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants