Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1716171] Make inert-retargeting-iframe.tentative.html more robust. #29355

Merged
merged 1 commit into from Jun 14, 2021

Conversation

moz-wptsync-bot
Copy link
Collaborator

@moz-wptsync-bot moz-wptsync-bot commented Jun 13, 2021

This change fixes two problems:

  1. an auto-positioned relative pos box may fall on a
    fractional pixel position. This breaks the test since it
    uses positionMove(), which throws if its params aren't
    integers:
    https://searchfox.org/mozilla-central/rev/0c7c41109902cb8967ec3ef2c0ddb326701cfbee/remote/marionette/action.js#743-745,750-752
  2. appending text (with ::after) when a click occurs made
    the text too wide to fit on one line and thus made these
    boxes have a larger height which caused them to get in
    the way of the intended target of the click.

Differential Revision: https://phabricator.services.mozilla.com/D117590

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1716171
gecko-commit: 1503a303a138ef34b15dd99dbe5adf5317b56d47
gecko-reviewers: emilio

This change fixes two problems:
1. an auto-positioned relative pos box may fall on a
fractional pixel position. This breaks the test since it
uses positionMove(), which throws if its params aren't
integers:
https://searchfox.org/mozilla-central/rev/0c7c41109902cb8967ec3ef2c0ddb326701cfbee/remote/marionette/action.js#743-745,750-752
2. appending text (with ::after) when a click occurs made
the text too wide to fit on one line and thus made these
boxes have a larger height which caused them to get in
the way of the intended target of the click.

Differential Revision: https://phabricator.services.mozilla.com/D117590

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1716171
gecko-commit: 1503a303a138ef34b15dd99dbe5adf5317b56d47
gecko-reviewers: emilio
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

@moz-wptsync-bot moz-wptsync-bot merged commit 246a325 into master Jun 14, 2021
20 checks passed
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1716171 branch Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants