Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite use of socket.error and socket.timeout errors #29362

Merged
merged 1 commit into from Jun 14, 2021

Conversation

foolip
Copy link
Member

@foolip foolip commented Jun 14, 2021

Part of these changes are made by pyupgrade, but it doesn't simplify use
of socket.timeout.

socket.error is now an alias of OSError:
https://docs.python.org/3/library/socket.html#socket.error

socket.timeout is now a subclass of OSError:
https://docs.python.org/3/library/socket.html#socket.timeout

Part of these changes are made by pyupgrade, but it doesn't simplify use
of socket.timeout.

socket.error is now an alias of OSError:
https://docs.python.org/3/library/socket.html#socket.error

socket.timeout is now a subclass of OSError:
https://docs.python.org/3/library/socket.html#socket.timeout
@wpt-pr-bot wpt-pr-bot added infra serve wave wpt wptrunner wptserve labels Jun 14, 2021
@wpt-pr-bot wpt-pr-bot requested a review from jgraham Jun 14, 2021
@foolip foolip mentioned this pull request Jun 14, 2021
@foolip foolip merged commit fefb741 into master Jun 14, 2021
33 checks passed
@foolip foolip deleted the foolip/socket-error-timeout branch Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra serve wave wpt wptrunner wptserve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants