Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GridNG] Placement of out of flow items in an undefined and empty grid #29363

Merged
merged 1 commit into from Jun 16, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 14, 2021

This CL fixes crashes that happened when either the start or end line of
an out of flow item is the first (and simultaneously, the last) line of
a grid whose columns and rows are not defined, and does not have any
grid items.

Bug: 1045599, 1218266, 1218613, 1218381
Change-Id: Ic291e92675da6795c905121a1967ed35361a1e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2957616
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#893180}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2957616 branch 2 times, most recently from c51f22a to d312a8b Compare Jun 16, 2021
This CL fixes crashes that happened when either the start or end line of
an out of flow item is the first (and simultaneously, the last) line of
a grid whose columns and rows are not defined, and does not have any
grid items.

Bug: 1045599, 1218266, 1218613, 1218381
Change-Id: Ic291e92675da6795c905121a1967ed35361a1e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2957616
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#893180}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 04a988b into master Jun 16, 2021
21 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2957616 branch Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants