Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResourceTiming]: Extend TAO-match.html test to cover more resource types #29364

Merged
merged 1 commit into from Jun 18, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 14, 2021

Since we have different code paths for loading different types of
resources, this CL adds tests for Timing-Allow-Origin parsing/checking
that exercise more resource types than before.

This test is actually failing right now for Chrome but should pass in
other browsers. Part of the reason to land this now is to see if other
browsers will need fixes too.

Bug: 1218565
Change-Id: Id274ec1fd914f62d3b805d4d69f81f2945a8baaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2956309
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#893912}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Extend TAO-match.html test to cover more resource types [ResourceTiming]: Extend TAO-match.html test to cover more resource types Jun 14, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2956309 branch 4 times, most recently from 3350b77 to 8bf527a Compare Jun 15, 2021
…ypes

Since we have different code paths for loading different types of
resources, this CL adds tests for Timing-Allow-Origin parsing/checking
that exercise more resource types than before.

This test is actually failing right now for Chrome but should pass in
other browsers. Part of the reason to land this now is to see if other
browsers will need fixes too.

Bug: 1218565
Change-Id: Id274ec1fd914f62d3b805d4d69f81f2945a8baaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2956309
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#893912}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8a1c240 into master Jun 18, 2021
22 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2956309 branch Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants