Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TableNG] Updated table-cell block-size definiteness rules. #29366

Merged
merged 1 commit into from Jun 14, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 14, 2021

Previously we considered a table-cell's block-size as definite if:

  • It had a fixed block-size.
  • The table had a specified block-size.

This appeared to be what we did previously, but not quite (due to legacy
complexity).
Instead this updates the rules to:

  • It had a fixed block-size.
  • The table had a specified block-size and it has grown (due to
    another table-cell being larger in the same row or similar).

This appears to be the same rules that EdgeHTML had. The updated
testcase:
tables/mozilla_expected_failures/bugs/bug131020-3.html

Now renders the same as EdgeHTML.

Bug: 1218345
Change-Id: If6f080b4828d2bc7eec424da7f4d06952ce29c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2959100
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892283}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Previously we considered a table-cell's block-size as definite if:
 - It had a fixed block-size.
 - The table had a specified block-size.

This appeared to be what we did previously, but not quite (due to legacy
complexity).
Instead this updates the rules to:
 - It had a fixed block-size.
 - The table had a specified block-size *and* it has grown (due to
   another table-cell being larger in the same row or similar).

This appears to be the same rules that EdgeHTML had. The updated
testcase:
tables/mozilla_expected_failures/bugs/bug131020-3.html

Now renders the same as EdgeHTML.

Bug: 1218345
Change-Id: If6f080b4828d2bc7eec424da7f4d06952ce29c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2959100
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892283}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 128525f into master Jun 14, 2021
22 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2959100 branch Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants