Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust test thresholds for Android #29367

Merged
merged 1 commit into from Jun 14, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 14, 2021

Adjust the test thresholds for these tests so that they pass on
Android. The changes in the thresholds are deemed small enough not to
significantly degrade detection of actual errors. These seem like
small round-off errors in the implementation on Android that differs
from other platforms.

Bug: 1212851
Change-Id: I58e853d02285e8b46df85462336ab0463adeae5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961534
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892308}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Adjust the test thresholds for these tests so that they pass on
Android.  The changes in the thresholds are deemed small enough not to
significantly degrade detection of actual errors.  These seem like
small round-off errors in the implementation on Android that differs
from other platforms.

Bug: 1212851
Change-Id: I58e853d02285e8b46df85462336ab0463adeae5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961534
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892308}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit b12b21f into master Jun 14, 2021
22 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2961534 branch Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants