Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sticky position pushed beyond scrollable range test. #29368

Merged
merged 1 commit into from Jun 16, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 14, 2021

The css-position spec[1] was updated to suggest that sticky positioned
elements are only shifted after layout within their containing block.
This would imply that the now unified behavior across browsers matches
the new spec expectations. This updates the test to match what the
browsers do.

[1] https://drafts.csswg.org/css-position-3/#stickypos-insets

Bug: 752022
Change-Id: Ic95d32948f9088ae4592a3de78d6ac0a58db8183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2960015
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892805}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

The css-position spec[1] was updated to suggest that sticky positioned
elements are only shifted after layout within their containing block.
This would imply that the now unified behavior across browsers matches
the new spec expectations. This updates the test to match what the
browsers do.

[1] https://drafts.csswg.org/css-position-3/#stickypos-insets

Bug: 752022
Change-Id: Ic95d32948f9088ae4592a3de78d6ac0a58db8183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2960015
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892805}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 05ab45f into master Jun 16, 2021
22 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2960015 branch Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants