Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpt] Fix grid aspect-ratio tests. #29369

Merged
merged 1 commit into from Jun 15, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 14, 2021

There two tests were asserting that "min-width: auto" would clamp the
inline-size to the available inline-size, even though we had a
transferred inline-size.

(Firefox has the same behaviour as us if "min-width: 0").
This updates the tests to respect the transferred inline-size.

Bug: 1203090
Change-Id: I02e10d3393f74cce0979b483629d1d6cea33d10d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961536
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892731}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

There two tests were asserting that "min-width: auto" would clamp the
inline-size to the available inline-size, even though we had a
transferred inline-size.

(Firefox has the same behaviour as us if "min-width: 0").
This updates the tests to respect the transferred inline-size.

Bug: 1203090
Change-Id: I02e10d3393f74cce0979b483629d1d6cea33d10d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961536
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892731}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit cf13290 into master Jun 15, 2021
22 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2961536 branch Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants