[css-flex] Migrate some abspos tests from reference to check-layout #29375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 15, 2021
The review process for this patch is being conducted in the Chromium project.
Before this patch, the entire test file is marked Fail even though each file has ~15-20 tests in it, some of which Blink passes. If we were to regress any of the tests we pass, we'd never know. Change-Id: Ibabe9dd435e23cedbcee5388170e976d896e9116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961720 Auto-Submit: David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#892693}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2961720
branch
from
2e220cf
to
d2d77b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Before this patch, the entire test file is marked Fail even though each
file has ~15-20 tests in it, some of which Blink passes. If we were to
regress any of the tests we pass, we'd never know.
Change-Id: Ibabe9dd435e23cedbcee5388170e976d896e9116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961720
Auto-Submit: David Grogan <dgrogan@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892693}