Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flex] Migrate some abspos tests from reference to check-layout #29375

Merged
merged 1 commit into from Jun 15, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 15, 2021

Before this patch, the entire test file is marked Fail even though each
file has ~15-20 tests in it, some of which Blink passes. If we were to
regress any of the tests we pass, we'd never know.

Change-Id: Ibabe9dd435e23cedbcee5388170e976d896e9116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961720
Auto-Submit: David Grogan <dgrogan@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892693}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Before this patch, the entire test file is marked Fail even though each
file has ~15-20 tests in it, some of which Blink passes. If we were to
regress any of the tests we pass, we'd never know.

Change-Id: Ibabe9dd435e23cedbcee5388170e976d896e9116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961720
Auto-Submit: David Grogan <dgrogan@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892693}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2961720 branch from 2e220cf to d2d77b8 Jun 15, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit d491d5f into master Jun 15, 2021
22 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2961720 branch Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants