Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require validation messages to have a parent at all times #29376

Merged
merged 1 commit into from Jun 15, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 15, 2021

Validation messages are presented at the top of a document when there
is invalid entry in a form. The accessibility object for these is only
created once, and either added or removed from the root object's
children depending on whether it's currently visible. This can lead
to a situation where it's marked dirty and the serializer tries to use
it, even when it's not currently part of the tree.

This CL removes the requirement for it to have a parent, in order to
avoid DCHECK()s that require all objects but the root to have a parent,
and repairs missing parents.

Another solution could be to detach and remove the validation message
object (validation_message_axid_), when it is not in use, and create
a new one each time one is needed.

Fixed: 1216847
Change-Id: I009ee1d2c46ad989182a0a4ff0c11381508a77c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961162
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#892471}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2961162 branch from a0107ae to 94962ef Jun 15, 2021
Validation messages are presented at the top of a document when there
is invalid entry in a form. The accessibility object for these is only
created once, and either added or removed from the root object's
children depending on whether it's currently visible. This can lead
to a situation where it's marked dirty and the serializer tries to use
it, even when it's not currently part of the tree.

This CL removes the requirement for it to have a parent, in order to
avoid DCHECK()s that require all objects but the root to have a parent,
and repairs missing parents.

Another solution could be to detach and remove the validation message
object (validation_message_axid_), when it is not in use, and create
a new one each time one is needed.

Fixed: 1216847
Change-Id: I009ee1d2c46ad989182a0a4ff0c11381508a77c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961162
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#892471}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2961162 branch from 94962ef to 24027ea Jun 15, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 33bfe04 into master Jun 15, 2021
18 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2961162 branch Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants