[css-fonts] Add tests for dynamic changes of font-palette property #30942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Sep 24, 2021
https://bugs.webkit.org/show_bug.cgi?id=230673 Reviewed by Antti Koivisto. It already works. The tests are being upstreamed at web-platform-tests/wpt#30942. * web-platform-tests/css/css-fonts/font-palette-add-2-expected.html: Added. * web-platform-tests/css/css-fonts/font-palette-add-2.html: Added. * web-platform-tests/css/css-fonts/font-palette-add-expected-mismatch.html: Added. * web-platform-tests/css/css-fonts/font-palette-add.html: Added. * web-platform-tests/css/css-fonts/font-palette-modify-2-expected.html: Added. * web-platform-tests/css/css-fonts/font-palette-modify-2.html: Added. * web-platform-tests/css/css-fonts/font-palette-modify-expected-mismatch.html: Added. * web-platform-tests/css/css-fonts/font-palette-modify.html: Added. * web-platform-tests/css/css-fonts/font-palette-remove-2-expected.html: Added. * web-platform-tests/css/css-fonts/font-palette-remove-2.html: Added. * web-platform-tests/css/css-fonts/font-palette-remove-expected-mismatch.html: Added. * web-platform-tests/css/css-fonts/font-palette-remove.html: Added. Canonical link: https://commits.webkit.org/242092@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
nt1m
approved these changes
Sep 24, 2021
|
This looks like a duplicate of #30939 on which I left some comment regarding waiting for document.fonts.ready to be resolved before snapshotting. |
|
This isn't a dup of #30939. That one is for |
litherum
force-pushed
the
font-palette-updates
branch
from
a1213f1
to
b3bf403
Compare
|
The linter error looks bogus - this version of Ahem is customized to include font palettes. |
litherum
force-pushed
the
font-palette-updates
branch
from
b3bf403
to
b31fb50
Compare
|
This patch is stale now; I've updated the font in #31044. |
The relevant WebKit bug is https://bugs.webkit.org/show_bug.cgi?id=230673.
litherum
force-pushed
the
font-palette-updates
branch
from
b31fb50
to
163e0ec
Compare
bertogg
pushed a commit
to Igalia/webkit
that referenced
this pull request
Oct 9, 2021
https://bugs.webkit.org/show_bug.cgi?id=230673 Reviewed by Antti Koivisto. It already works. The tests are being upstreamed at web-platform-tests/wpt#30942. * web-platform-tests/css/css-fonts/font-palette-add-2-expected.html: Added. * web-platform-tests/css/css-fonts/font-palette-add-2.html: Added. * web-platform-tests/css/css-fonts/font-palette-add-expected-mismatch.html: Added. * web-platform-tests/css/css-fonts/font-palette-add.html: Added. * web-platform-tests/css/css-fonts/font-palette-modify-2-expected.html: Added. * web-platform-tests/css/css-fonts/font-palette-modify-2.html: Added. * web-platform-tests/css/css-fonts/font-palette-modify-expected-mismatch.html: Added. * web-platform-tests/css/css-fonts/font-palette-modify.html: Added. * web-platform-tests/css/css-fonts/font-palette-remove-2-expected.html: Added. * web-platform-tests/css/css-fonts/font-palette-remove-2.html: Added. * web-platform-tests/css/css-fonts/font-palette-remove-expected-mismatch.html: Added. * web-platform-tests/css/css-fonts/font-palette-remove.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@283032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I haven't updated the test font yet, like I said I would in #30910 (comment). However, these tests don't require those updates.)
The relevant WebKit bug is https://bugs.webkit.org/show_bug.cgi?id=230673.