Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presentation-api idlharness update #3238

Merged
merged 2 commits into from Jul 4, 2016

Conversation

@louaybassbouss
Copy link
Contributor

commented Jun 27, 2016

update idlharness.html with latest Presentation API interfaces from the ED.

@hoppipolla-critic-bot

This comment has been minimized.

Copy link

commented Jun 27, 2016

Critic review: https://critic.hoppipolla.co.uk/r/6666

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@louaybassbouss

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2016

@zqzhang can you review and merge. I created a snapshot from the ED but I think there are minor changes comparing to the current idlharness.

@louaybassbouss louaybassbouss referenced this pull request Jun 27, 2016
6 of 7 tasks complete
@Honry

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2016

@louaybassbouss , please fix the lint error.
INDENT TABS:presentation-api/receiving-ua/idlharness.html

@@ -36,15 +36,16 @@
[Constructor(DOMString url)]

This comment has been minimized.

Copy link
@Honry

Honry Jun 28, 2016

Contributor

I just check the latest spec at Interface PresentationRequest, the constructor has been changed to [Constructor(DOMString url), Constructor(DOMString[] urls)]

@zqzhang

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2016

Thanks @Honry for the review. @louaybassbouss please drop me a note when you address the comments above.

@louaybassbouss

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2016

Done. @Honry @zqzhang please review and merge

@Honry

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2016

LGTM 😄

@zqzhang zqzhang merged commit 29af5df into web-platform-tests:master Jul 4, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ddorwin added a commit to ddorwin/web-platform-tests that referenced this pull request Sep 13, 2016
* * update idlharness.html with latest Presentation API interfaces from the ED

* * update idlharness for presentation API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.