Add test for CustomElementRegistry getName interface#39640
Closed
keithamus wants to merge 2 commits into
Closed
Conversation
wpt-pr-bot
requested review from
TakayoshiKochi,
domenic,
hayatoito,
kojiishi,
rniwa and
snuggs
This was referenced Apr 21, 2023
rniwa
reviewed
Apr 21, 2023
rniwa
reviewed
Apr 21, 2023
rniwa
reviewed
Apr 21, 2023
rniwa
reviewed
Apr 21, 2023
rniwa
requested changes
Apr 21, 2023
Contributor
rniwa
left a comment
rniwa
left a comment
There was a problem hiding this comment.
Please address above comments.
Member
Author
|
@rniwa above comments have been addressed, I believe. |
rniwa
approved these changes
Apr 25, 2023
Member
Author
|
Closed by #39709 |
mnutt
pushed a commit
to movableink/webkit
that referenced
this pull request
Jun 28, 2023
https://bugs.webkit.org/show_bug.cgi?id=257759 Reviewed by Chris Dumez. Update the implementation of CustomElementsRegistry.prototype.getName to match the latest PR. Namely, it now returns DOMString? instead of (DOMString or undefined): whatwg/html#9195 web-platform-tests/wpt#39640 * LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html: * Source/WebCore/dom/CustomElementRegistry.cpp: (WebCore::CustomElementRegistry::getName): * Source/WebCore/dom/CustomElementRegistry.h: * Source/WebCore/dom/CustomElementRegistry.idl: Canonical link: https://commits.webkit.org/264916@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CustomElements v0 you could use the
.namefield to get the defined tag name, but CustomElements v1 does not offer such a field.localNamecan be used within an instance but this prohibits use in, for example, static methods.This was discussed in the WCCG F2F, tracked in
WICG/webcomponents#566. The conclusion of the F2F was to write up a spec change and WPT tests.