Ensure that pointerUp Action is Being Issued on Element Being Tested
#43214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There does not seem to be any guarantee that the pointer will move between actions.
|
@dshin-moz it looks like this breaks the test in Firefox instead: Did you intend for that to happen? |
|
Hm.. That's unfortunate - Looking at the logs, the failures happen before the changed line. Checking locally with |
* `pointerMove` origins set on elements instead of viewport + clientRect location * Specifically wait on promise fulfilled microtask being queued after relevant events are emitted * Break down the tests so that one test don't rely on the pointer hovering over where the previous test put it
foolip
reviewed
Nov 27, 2023
css/selectors/invalidation/user-action-pseudo-classes-in-has.html
Outdated
Show resolved
Hide resolved
No need to depend on event - Dispatched actions are [guaranteed](https://www.w3.org/TR/webdriver2/#dfn-dispatch-actions-inner) to resolve after DOM events generated by actions are processed.
foolip
reviewed
Nov 28, 2023
dshin-moz
commented
Nov 28, 2023
Keep the test that invalidates from `:has(:hover:active)` -> `:has(:hover)`.
foolip
approved these changes
Nov 30, 2023
|
I'm going to admin merge to override the Firefox stability failure. @dshin-moz can you file a Gecko issue for that if it's something you think warrants further investigation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There does not seem to be any guarantee that the pointer will move between actions.
Fixes web-platform-tests/interop#606 - verified on local Chromium build.