Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE: Subsumption Algorithm -- Part 5 #4338

Closed
wants to merge 1 commit into from

Conversation

@aubakirova
Copy link
Contributor

@aubakirova aubakirova commented Dec 15, 2016

Tests for wildcard lists (*)
@mikewest

@wpt-pr-bot
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot commented Dec 15, 2016

@aubakirova aubakirova force-pushed the aubakirova:part1.5 branch 2 times, most recently from c6c617b to 9d68d6e Dec 15, 2016
@mikewest mikewest self-assigned this Dec 16, 2016
@aubakirova aubakirova force-pushed the aubakirova:part1.5 branch 2 times, most recently from b755efa to 34cc245 Dec 16, 2016
@aubakirova
Copy link
Contributor Author

@aubakirova aubakirova commented Dec 16, 2016

Rebased!

{ "name" : "Wildcard list subsumes an empty source list.",
"required_csp": "img-src *",
"returned_csp_1": "img-src ",
"returned_csp_2": null,

This comment has been minimized.

@mikewest

mikewest Dec 16, 2016
Contributor

Nit: Just leave this off.

@aubakirova aubakirova force-pushed the aubakirova:part1.5 branch from 73149f7 to 57cbe39 Dec 27, 2016
@foolip
Copy link
Member

@foolip foolip commented Aug 16, 2018

Oops, this was approved but never merged, probably because of the failing "code-review/reviewable" check. @aubakirova, although there are no conflicts, can you rebase this on master and see if the test still works? That will also trigger another check run, and if it passes we can merge this.

@wpt-pr-bot wpt-pr-bot requested review from andypaicu and hillbrad Aug 16, 2018
@foolip
Copy link
Member

@foolip foolip commented Aug 16, 2018

@andypaicu, might you be able to revive this PR?

@gsnedders
Copy link
Contributor

@gsnedders gsnedders commented Feb 22, 2021

landed in #27727

@gsnedders gsnedders closed this Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants