Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for constructed stylesheet invalidation #44651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add tests for constructed stylesheet invalidation #44651

wants to merge 1 commit into from
+49 −0

Conversation

keithamus
Copy link
Contributor

When experimenting with constructed CSSStyleSheets I noticed they don't always invalidate properly in Safari, so here are some tests that assert on style invalidation in various forms.

@knowler
Copy link
Contributor

knowler commented Feb 19, 2024 •
edited

In Safari, this issue exists when working with a StylePropertyMap as well (i.e. the styleMap property for the CSSStyleRule instead of style using a slightly different API), would it make sense to add the tests for that here too?

@nt1m
Copy link
Member

nt1m commented Feb 19, 2024

Is there a WebKit bug filed?

@keithamus
Copy link
Contributor Author

Just filed https://bugs.webkit.org/show_bug.cgi?id=269717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio Awaiting requested review from emilio

@nt1m nt1m Awaiting requested review from nt1m

@dbaron dbaron Awaiting requested review from dbaron

@lilles lilles Awaiting requested review from lilles

@plinss plinss Awaiting requested review from plinss

At least 1 approving review is required to merge this pull request.

Assignees

@dbaron dbaron

Labels
cssom wg-css
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@keithamus @knowler @nt1m @dbaron @wpt-pr-bot