Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test same origin-domain for BC containers and allowpaymentrequest #4615

Merged
merged 2 commits into from Jan 25, 2017

Conversation

@zcorpan
Copy link
Member

commented Jan 24, 2017

This tests the first 4 items in #4526.

@wpt-stability-bot

This comment has been minimized.

Copy link

commented Jan 24, 2017

Firefox (nightly channel)

Testing web-platform-tests at revision 28089bc
Using browser at version BuildID 20170123125947; SourceStamp 36486fdc3813ef7943ae5b07b4128866d1938a6c
Starting 10 test iterations
All results were stable

All results

/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html
Subtest Results
OK
PaymentRequest setting allowpaymentrequest after document creation, before response FAIL
/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https.html
Subtest Results
OK
frame FAIL
object FAIL
embed FAIL
iframe FAIL
/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https.html
Subtest Results
OK
frame FAIL
object FAIL
embed FAIL
iframe FAIL
/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https.html
Subtest Results
OK
frame FAIL
object FAIL
embed FAIL
iframe FAIL
/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https.html
Subtest Results
OK
frame FAIL
object FAIL
embed FAIL
iframe FAIL
/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub.html
Subtest Results
OK
PaymentRequest removing allowpaymentrequest after load and then navigating FAIL
/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub.html
Subtest Results
OK
PaymentRequest setting allowpaymentrequest after load and then navigating FAIL
@wpt-stability-bot

This comment has been minimized.

Copy link

commented Jan 24, 2017

Chrome (unstable channel)

Testing web-platform-tests at revision 28089bc
Using browser at version 55.0.2883.75
Starting 10 test iterations
All results were stable

All results

/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html
Subtest Results
ERROR
PaymentRequest setting allowpaymentrequest after document creation, before response FAIL
/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https.html
Subtest Results
ERROR
frame FAIL
object FAIL
embed FAIL
iframe FAIL
/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https.html
Subtest Results
ERROR
frame FAIL
object FAIL
embed FAIL
iframe FAIL
/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https.html
Subtest Results
ERROR
frame FAIL
object FAIL
embed FAIL
iframe FAIL
/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https.html
Subtest Results
ERROR
frame FAIL
object FAIL
embed FAIL
iframe FAIL
/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub.html
Subtest Results
ERROR
PaymentRequest removing allowpaymentrequest after load and then navigating FAIL
/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub.html
Subtest Results
ERROR
PaymentRequest setting allowpaymentrequest after load and then navigating FAIL
@zcorpan zcorpan force-pushed the zcorpan/allowpaymentrequest-same-origin branch from 40c221d to 8458bbc Jan 24, 2017
@zcorpan

This comment has been minimized.

Copy link
Member Author

commented Jan 24, 2017

OK this is ready for review; I will do separate pull requests for the other items in #4526 to keep each pull request reasonably small and reviewable.

@foolip r?

@foolip
foolip approved these changes Jan 25, 2017

window.onmessage = (e) => {
const result = e.data;
const t = tests[result.urlQuery];

This comment has been minimized.

Copy link
@foolip

foolip Jan 25, 2017

Contributor

Can you extract out a const tagName = result.urlQuery for clarity?

@foolip

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2017

👍

@zcorpan zcorpan referenced this pull request Jan 25, 2017
2 of 4 tasks complete
@zcorpan zcorpan force-pushed the zcorpan/allowpaymentrequest-same-origin branch from 30816e5 to 39ce250 Jan 25, 2017
@zcorpan zcorpan merged commit 5525244 into master Jan 25, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@zcorpan zcorpan deleted the zcorpan/allowpaymentrequest-same-origin branch Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.