Repository navigation
Fix bug in URL setter test harness, and modernize - #51369
Merged
Merged
Conversation
Because we were using var instead of let, the closure was capturing only the last value for test_case. So we were only ever running one of the setter test cases (repeatedly) per property. A minor fix would be to move from var to let. But, instead I just modernized these files completely.
annevk
approved these changes
Mar 15, 2025
annevk
left a comment
annevk
left a comment
Member
There was a problem hiding this comment.
Nice, looks like the results are identical (in Safari, anyway).
This was referenced Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we were using var instead of let, the closure was capturing only the last value for test_case. So we were only ever running one of the setter test cases (repeatedly) per property.
A minor fix would be to move from var to let. But, instead I just modernized these files completely.
(Found as part of jsdom/whatwg-url#268.)