WebNN: Add some 1D tests for reduce op with empty axes#51493
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Mar 24, 2025
Merged
WebNN: Add some 1D tests for reduce op with empty axes#51493chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
According to the WebNN specification[1], if the `axes` parameter is empty, the reduction function is applied to each value in the tensor individually, with no dimensions being reduced. Currently, most of the reduce tests focus only on this case for 0D inputs, which is insufficient for thorough verification. For example, with a 0D input, operations like `reduceMin` and `reduceMean` that reduce each value individually are effectively no-ops. However, for 1D inputs, we can better verify the behavior of reducing each value individually. [1] https://webmachinelearning.github.io/webnn/#api-mlgraphbuilder-reduce Bug: 404004620 Change-Id: I61a358c9a3e393adf8b69b87310c426976581c70 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6359997 Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Mingming1 Xu <mingming1.xu@intel.com> Cr-Commit-Position: refs/heads/main@{#1436675}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6359997
branch
from
4bc4ae2 to
6467e89
Compare
wpt-pr-bot
approved these changes
Mar 24, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the WebNN specification[1], if the
axesparameter isempty, the reduction function is applied to each value in the tensor
individually, with no dimensions being reduced. Currently, most of
the reduce tests focus only on this case for 0D inputs, which is
insufficient for thorough verification. For example, with a 0D input,
operations like
reduceMinandreduceMeanthat reduce each valueindividually are effectively no-ops. However, for 1D inputs, we can
better verify the behavior of reducing each value individually.
[1] https://webmachinelearning.github.io/webnn/#api-mlgraphbuilder-reduce
Bug: 404004620
Change-Id: I61a358c9a3e393adf8b69b87310c426976581c70
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6359997
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Commit-Queue: Mingming1 Xu <mingming1.xu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1436675}