Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geometry] Test that DOMMatrix CSS parsing is not exposed in workers #5769

Merged
merged 3 commits into from May 4, 2017

Conversation

@zcorpan
Copy link
Member

commented May 3, 2017

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2017

zcorpan added a commit to w3c/fxtf-drafts that referenced this pull request May 3, 2017
[geometry] Do not expose CSS parser in workers for DOMMatrix
Annotate setMatrixValue with [Exposed=Window] and throw TypeError
when DOMMatrix/DOMMatrixReadOnly is constructed with a string
if the current global is not a Window.

Fixes #122.

Tests: web-platform-tests/wpt#5769
@w3c-bots

This comment has been minimized.

Copy link

commented May 3, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 9d68b49
Using browser at version BuildID 20170503100422; SourceStamp 82c2d17e74ef9cdf38a5d5ac4eb3ae846ec30ba4
Starting 10 test iterations
All results were stable

All results

1 test ran
/css/geometry-1/DOMMatrix-css-string.worker.html
Subtest Results Messages
OK
DOMMatrix constructor with string argument in worker FAIL assert_true: DOMMatrix should exist expected true got false
DOMMatrixReadOnly constructor with string argument in worker FAIL assert_true: DOMMatrixReadOnly should exist expected true got false
DOMMatrix setMatrixValue in worker FAIL DOMMatrix is not defined
@w3c-bots

This comment has been minimized.

Copy link

commented May 3, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 955a5991c499b61faf6ef77283a527597c5d3628
Using browser at version 60.0.3080.5 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/css/geometry-1/DOMMatrix-css-string.worker.html
Subtest Results Messages
OK
DOMMatrix constructor with string argument in worker FAIL assert_true: DOMMatrix should exist expected true got false
DOMMatrixReadOnly constructor with string argument in worker FAIL assert_true: DOMMatrixReadOnly should exist expected true got false
DOMMatrix setMatrixValue in worker FAIL DOMMatrix is not defined

@wpt-pr-bot wpt-pr-bot added the infra label May 3, 2017

@foolip
foolip approved these changes May 3, 2017
Copy link
Contributor

left a comment

LGTM % nit


['DOMMatrix', 'DOMMatrixReadOnly'].forEach(constr => {
test(() => {
assert_true(constr in self, `${constr} is not supported`);

This comment has been minimized.

Copy link
@foolip

foolip May 3, 2017

Contributor

When this fails, it will be "assert_true: DOMMatrix is not supported expected true got false". In other words, the description is inverted, if it describes the expected value (maybe "self.${constr} exists") then the message will make sense. Or just no description since there's just one assert_true in the test.

This comment has been minimized.

Copy link
@zcorpan

zcorpan May 4, 2017

Author Member

Changed to ${constr} should exist

zcorpan added a commit to w3c/fxtf-drafts that referenced this pull request May 4, 2017
[geometry] Do not expose CSS parser in workers for DOMMatrix
Annotate setMatrixValue with [Exposed=Window] and throw TypeError
when DOMMatrix/DOMMatrixReadOnly is constructed with a string
if the current global is not a Window.

Fixes #122.

Tests: web-platform-tests/wpt#5769

@zcorpan zcorpan merged commit 5629382 into master May 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zcorpan zcorpan deleted the zcorpan/dommatrix-css-parsing branch May 4, 2017

zcorpan added a commit that referenced this pull request May 19, 2017
zcorpan added a commit that referenced this pull request May 19, 2017

@gsnedders gsnedders added geometry and removed geometry-1 labels Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.