Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[intersection-observer] Test isIntersecting change events #7215

Merged
merged 2 commits into from May 17, 2018

Conversation

Projects
None yet
7 participants
@nolanlawson
Copy link
Member

nolanlawson commented Aug 31, 2017

This is a test for the change introduced in w3c/IntersectionObserver#245. The main difference with the previous version of the spec is that the observer fires events when isIntersecting changes but thresholdsIndex does not, which covers some odd edge-adjacency scenarios.

On my machine, Chrome 60 and Edge 16 prerelease (e.g. public insider 16275) pass the 5 new tests, whereas Firefox Nightly (57.0a1 2017-08-31) does not. This is to be expected given discussion in w3c/IntersectionObserver#222.

/cc @szager-chromium @tobytailor @scottlow

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Aug 31, 2017

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Aug 31, 2017

Build PASSED

Started: 2017-08-31 22:18:01
Finished: 2017-08-31 22:27:23

Failing Jobs

  • chrome:unstable
  • safari:10.0
  • MicrosoftEdge:14.14393

View more information about this build on:

@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Aug 31, 2017

@tobytailor Are you able to review this?

@sideshowbarker

This comment has been minimized.

Copy link
Member

sideshowbarker commented Sep 1, 2017

w3c-test:mirror

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Apr 13, 2018

@scottlow @szager-chromium are you able to review this?

@nolanlawson can you rebase it so that Travis runs again?

@nolanlawson nolanlawson force-pushed the nolanlawson:nolan/intersection-observer branch from e4bf8a3 to 25c616d May 17, 2018

@nolanlawson

This comment has been minimized.

Copy link
Member Author

nolanlawson commented May 17, 2018

rebased ^

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented May 17, 2018

w3c-test:mirror

@foolip

foolip approved these changes May 17, 2018

Copy link
Contributor

foolip left a comment

Manually confirmed http://w3c-test.org/submissions/7215/intersection-observer/isIntersecting-change-events.html to be passing in Chrome, Edge and Firefox. Safari fails with "Can't find variable: IntersectionObserver"

@foolip foolip merged commit f40b9f3 into web-platform-tests:master May 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.