Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[testharness.js] Honor promises from cleanup fns #8748
Extend the implementation of the
This behavior prevents tests from being run synchronously. In order to
Ensure that this implementation does not introduce a new dependency on
The return value of the function provided to
Detect cases where an invalid value is returned and trigger immediate
This patch is intended to resolve gh-6075. Since filing that issue, I've
After a brief investigation into the current usage of
This patch avoids introducing a dependency on the global
Also note that as of yesterday, any change to the contents of
referenced this pull request
Dec 20, 2017
I'm trying the changes in https://chromium-review.googlesource.com/c/chromium/src/+/836619 since our CI here isn't able to handle changes this big.
Lots of comments, but this is looking really good. I'll be around today and tomorrow to keep reviewing.
There are rather a lot of new failures with new harness errors in https://chromium-review.googlesource.com/c/chromium/src/+/836619 that may be related:
There are some outside of wpt too, but probably the same root cause.
@jugglinmike, can you check the above and see if there are real regressions here?