New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename quirks-mode to quirks to match the standard shortname #8895

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
4 participants
@annevk
Member

annevk commented Jan 4, 2018

See whatwg/quirks#20.

grep -r quirks-mode * yielded nothing so nothing external relies on this being here it appears.

Rename quirks-mode to quirks to match the standard shortname
See whatwg/quirks#20.

`grep -r quirks-mode *` yielded nothing so nothing external relies on this being here it appears.
@wpt-pr-bot

This comment has been minimized.

Show comment
Hide comment
@wpt-pr-bot

wpt-pr-bot Jan 4, 2018

Collaborator

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

Collaborator

wpt-pr-bot commented Jan 4, 2018

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@w3c-bots

This comment has been minimized.

Show comment
Hide comment
@w3c-bots

w3c-bots Jan 4, 2018

Build PASSED

Started: 2018-01-04 10:06:19
Finished: 2018-01-04 10:08:28

Failing Jobs

  • MicrosoftEdge:14.14393

View more information about this build on:

w3c-bots commented Jan 4, 2018

Build PASSED

Started: 2018-01-04 10:06:19
Finished: 2018-01-04 10:08:28

Failing Jobs

  • MicrosoftEdge:14.14393

View more information about this build on:

@jdm

jdm approved these changes Jan 4, 2018

@annevk annevk merged commit 0361989 into master Jan 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the annevk/rn-quirks-mode branch Jan 4, 2018

foolip added a commit that referenced this pull request Jan 5, 2018

Move XMLHttpRequest/ to xhr/
Like #8895 for quirks,
this adapts to whatwg/xhr#184, after which the
wpt links are generated and match the shortname.
https://xhr.spec.whatwg.org/ currently has a 404 link to
https://github.com/w3c/web-platform-tests/tree/master/xhr.

foolip added a commit to foolip/day-to-day that referenced this pull request Jan 5, 2018

foolip added a commit that referenced this pull request Jan 6, 2018

Move XMLHttpRequest/ to xhr/
Like #8895 for quirks,
this adapts to whatwg/xhr#184, after which the
wpt links are generated and match the shortname.
https://xhr.spec.whatwg.org/ currently has a 404 link to
https://github.com/w3c/web-platform-tests/tree/master/xhr.

Steps taken:
 * rename the directory
 * sed 's#/XMLHttpRequest#/xhr#g' everywhere
 * manually handle a few remaining cases of "XMLHttpRequest/"
 * look at ouput of grep -E '\SXMLHttpRequest' and 'XMLHttpRequest[^(;]'

zcorpan added a commit to whatwg/quirks that referenced this pull request Jan 8, 2018

zcorpan added a commit to whatwg/quirks that referenced this pull request Jan 8, 2018

ardalanamini pushed a commit to siliconjs/chromium that referenced this pull request Jan 9, 2018

Move wpt OWNERS files to match upstream directory renames
See:
web-platform-tests/wpt#8895
web-platform-tests/wpt#8937

No-Try: true
Change-Id: I070add93a9dc94206b9c78bf7461a6727228f267
Reviewed-on: https://chromium-review.googlesource.com/852834
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528040}

aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 16, 2018

Remove a few entries from W3CImportExpectations
external/wpt/FileAPI/BlobURL/test1-manual.html and
external/wpt/FileAPI/BlobURL/test3-manual.html were removed in
web-platform-tests/wpt#8612

external/wpt/quirks-mode/active-and-hover-manual.html was renamed in
web-platform-tests/wpt#8895, and the new name is now
in NeverFixTests.

Change-Id: I04804bfc5f9a3d37b44e5bc0f45308e6fe8bd639
Reviewed-on: https://chromium-review.googlesource.com/966289
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543700}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment