Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USVString] Change the type of url with USVString in navigator.sendBeacon #9079

Merged
merged 1 commit into from Jan 18, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 18, 2018

Latest spec has used USVString instead of DOMString for url argument.

This CL replaces DOMString type with USVString type according to the spec.

Bug: 790860
Change-Id: I66825c20395ea6fd6b26e32fc8f6508fd85aeef7
Reviewed-on: https://chromium-review.googlesource.com/869970
Reviewed-by: Takeshi Yoshino tyoshino@chromium.org
Commit-Queue: Gyuyoung Kim gyuyoung.kim@lge.com
Cr-Commit-Position: refs/heads/master@{#530123}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 18, 2018

Build ERRORED

Started: 2018-01-18 13:00:32
Finished: 2018-01-18 13:10:20

Failing Jobs

  • firefox:nightly

View more information about this build on:

[USVString] Change the type of url with USVString in navigator.sendBe…
…acon

Latest spec has used USVString instead of DOMString for url argument.
 - spec: https://w3c.github.io/beacon/#dom-navigator-sendbeacon

This CL replaces DOMString type with USVString type according to the spec.

Bug: 790860
Change-Id: I66825c20395ea6fd6b26e32fc8f6508fd85aeef7
Reviewed-on: https://chromium-review.googlesource.com/869970
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#530123}
@Hexcles

This comment has been minimized.

Copy link
Member

Hexcles commented Jan 18, 2018

Firefox job failed because of Unicode encoding issues in the infra #8285

Awaiting admin-merge.

@Hexcles

This comment has been minimized.

Copy link
Member

Hexcles commented Jan 18, 2018

Pinging @gsnedders @jgraham @foolip for an admin-merge. It's currently blocking the export of a follow-up change.

@gsnedders gsnedders merged commit 9fbcfa4 into master Jan 18, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@gsnedders gsnedders deleted the chromium-export-cl-869970 branch Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.