Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-align] overflow-position keyword must have a fixed position #9085

Merged
merged 1 commit into from Jan 19, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 18, 2018

There were several discussions to avoid ambiguities with the complex
values, specially when it comes to define the place-xxx shorthands.

One of the sources of problems is the 'overflow-position' keyword. The
CSS WG has decided to change the syntax of all the CSS Box Alignment
properties so that the 'overflow-position' keyword always precede the
'self-position' or the 'content-position' keywords.

w3c/csswg-drafts#1446 (comment)

In order to apply this change to the Content Distribution properties'
(align-content and justify-content) syntax I had to completely
re-implement their parsing function. Thanks to this I addressed also
the issue with the content-distribution fallback, which cannot be
specified explicitly now.

w3c/csswg-drafts#1002 (reference)

Bug: 802098, 802247
Change-Id: I57315a475940c00d0c0dafbb4f1b32a2c6c1ff68
Reviewed-on: https://chromium-review.googlesource.com/868531
Commit-Queue: Javier Fernandez jfernandez@igalia.com
Reviewed-by: meade_UTC10 meade@chromium.org
Reviewed-by: Manuel Rego Casasnovas rego@igalia.com
Cr-Commit-Position: refs/heads/master@{#530416}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 18, 2018

Build PASSED

Started: 2018-01-19 03:32:05
Finished: 2018-01-19 04:00:49

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:14.14393

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-868531 branch from 7b51db2 to 4bd6697 Jan 18, 2018

@wpt-pr-bot wpt-pr-bot added the css-grid label Jan 18, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-868531 branch 2 times, most recently from fd29e1c to fbdba47 Jan 18, 2018

[css-align] overflow-position keyword must have a fixed position
There were several discussions to avoid ambiguities with the complex
values, specially when it comes to define the place-xxx shorthands.

One of the sources of problems is the 'overflow-position' keyword. The
CSS WG has decided to change the syntax of all the CSS Box Alignment
properties so that the 'overflow-position' keyword always precede the
'self-position' or the 'content-position' keywords.

w3c/csswg-drafts#1446 (comment)

In order to apply this change to the Content Distribution properties'
(align-content and justify-content) syntax I had to completely
re-implement their parsing function. Thanks to this I addressed also
the issue with the content-distribution fallback, which cannot be
specified explicitly now.

w3c/csswg-drafts#1002 (reference)

Bug: 802098, 802247
Change-Id: I57315a475940c00d0c0dafbb4f1b32a2c6c1ff68
Reviewed-on: https://chromium-review.googlesource.com/868531
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#530416}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-868531 branch from fbdba47 to 63d002a Jan 19, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 29f6596 into master Jan 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-868531 branch Jan 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.