Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new ComputedStyle instance for kNoChange. #9086

Merged
merged 1 commit into from Jan 19, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 18, 2018

Even if the computed style doesn't change, AffectedBy* flags may have
changed, which means we need to set the current ComputedStyle to the new
instance. We can however skip any invalidation diffs.

This is a re-land of the revert of this functionality which did not make
us recover from the memory regression reported in 771294.

Bug: 768406, 771294
Change-Id: Icc7eeee8a982eed53243d52d04d45e313d79a10d
Reviewed-on: https://chromium-review.googlesource.com/870391
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/heads/master@{#530468}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 18, 2018

Build PASSED

Started: 2018-01-19 10:28:16
Finished: 2018-01-19 10:33:32

View more information about this build on:

Use new ComputedStyle instance for kNoChange.
Even if the computed style doesn't change, AffectedBy* flags may have
changed, which means we need to set the current ComputedStyle to the new
instance. We can however skip any invalidation diffs.

This is a re-land of the revert of this functionality which did not make
us recover from the memory regression reported in 771294.

Bug: 768406, 771294
Change-Id: Icc7eeee8a982eed53243d52d04d45e313d79a10d
Reviewed-on: https://chromium-review.googlesource.com/870391
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530468}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-870391 branch from 696a7e8 to e5643b0 Jan 19, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit cd052aa into master Jan 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-870391 branch Jan 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.