Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch unexpected exceptions in sync-xhr test. #9091

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 18, 2018

With this change, only the expected NetworkError from send() will be
propagated to the feature policy test framework. Other errors (including
NetworkErrors from other calls) will be prefixed with
"UnexpectedException:" and will cause the tests to fail.

Bug: 661283
Change-Id: I75e2fa6526211cc87c65f5f03e926903ae1ba22e
Reviewed-on: https://chromium-review.googlesource.com/874270
Commit-Queue: Philip Jägenstedt foolip@chromium.org
Reviewed-by: Philip Jägenstedt foolip@chromium.org
Cr-Commit-Position: refs/heads/master@{#530527}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 18, 2018

Build PASSED

Started: 2018-01-23 04:12:38
Finished: 2018-01-23 04:21:46

View more information about this build on:

Catch unexpected exceptions in sync-xhr test.
With this change, only the expected NetworkError from send() will be
propagated to the feature policy test framework. Other errors (including
NetworkErrors from other calls) will be prefixed with
"UnexpectedException:" and will cause the tests to fail.

Bug: 661283
Change-Id: I75e2fa6526211cc87c65f5f03e926903ae1ba22e
Reviewed-on: https://chromium-review.googlesource.com/874270
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530527}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-874270 branch from 828ab49 to d287f27 Jan 19, 2018

@gsnedders gsnedders closed this Jan 23, 2018

@gsnedders gsnedders reopened this Jan 23, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8f6cb93 into master Jan 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-874270 branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.