Catch unexpected exceptions in sync-xhr test. #9091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 18, 2018
Build PASSEDStarted: 2018-01-23 04:12:38 View more information about this build on: |
With this change, only the expected NetworkError from send() will be propagated to the feature policy test framework. Other errors (including NetworkErrors from other calls) will be prefixed with "UnexpectedException:" and will cause the tests to fail. Bug: 661283 Change-Id: I75e2fa6526211cc87c65f5f03e926903ae1ba22e Reviewed-on: https://chromium-review.googlesource.com/874270 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#530527}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-874270
branch
from
828ab49
to
d287f27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, only the expected NetworkError from send() will be
propagated to the feature policy test framework. Other errors (including
NetworkErrors from other calls) will be prefixed with
"UnexpectedException:" and will cause the tests to fail.
Bug: 661283
Change-Id: I75e2fa6526211cc87c65f5f03e926903ae1ba22e
Reviewed-on: https://chromium-review.googlesource.com/874270
Commit-Queue: Philip Jägenstedt foolip@chromium.org
Reviewed-by: Philip Jägenstedt foolip@chromium.org
Cr-Commit-Position: refs/heads/master@{#530527}