Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enable as many external/wpt/css/CSS2/ tests as possible. #9093

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 18, 2018

A few were skipped for no reason. Some of them turned out to pass, while
others fail. Then there were quite a few manual tests, and those we
still need to skip.

Made some (mostly minor) changes to some of the tests to make
them pass. They were making invalid assumptions about
fonts (glyphs with unexpected negative bearing, kerning, etc.)
and line heights. One test was also assuming that painting the
same glyph multiple times would produce the exact same result as
painting it just once, but that's not necessarily true for
anti-aliasing.

It was pretty hard to figure out what
floats-clear/floats-028-ref.xht was about (old IE bug fixed?),
but I made the ref more similar to the test, so that we don't
make assumptions about line height.

Also updated expectations for LayoutNG, because it turned out that more
more of these tests pass there.

Bug: 711704, 711709, 711805, 711807
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I6e34e037852ef31cfe8d85688865823d6f9d2d0a
Reviewed-on: https://chromium-review.googlesource.com/873310
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Reviewed-by: Emil A Eklund eae@chromium.org
Reviewed-by: Koji Ishii kojii@chromium.org
Cr-Commit-Position: refs/heads/master@{#531322}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 18, 2018

Build PENDING

Started: None
Finished: None

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Enable as many external/wpt/css/CSS2/ tests as possible. Fix and enable as many external/wpt/css/CSS2/ tests as possible. Jan 18, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-873310 branch 4 times, most recently from dfa96c6 to d991742 Jan 18, 2018

Fix and enable as many external/wpt/css/CSS2/ tests as possible.
A few were skipped for no reason. Some of them turned out to pass, while
others fail. Then there were quite a few manual tests, and those we
still need to skip.

Made some (mostly minor) changes to some of the tests to make
them pass. They were making invalid assumptions about
fonts (glyphs with unexpected negative bearing, kerning, etc.)
and line heights. One test was also assuming that painting the
same glyph multiple times would produce the exact same result as
painting it just once, but that's not necessarily true for
anti-aliasing.

It was pretty hard to figure out what
floats-clear/floats-028-ref.xht was about (old IE bug fixed?),
but I made the ref more similar to the test, so that we don't
make assumptions about line height.

Also updated expectations for LayoutNG, because it turned out that more
more of these tests pass there.

Bug: 711704, 711709, 711805, 711807
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I6e34e037852ef31cfe8d85688865823d6f9d2d0a
Reviewed-on: https://chromium-review.googlesource.com/873310
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531322}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-873310 branch from d991742 to 8a5f2df Jan 23, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a289ff1 into master Jan 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-873310 branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.