Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[USVString] Change the type of url with USVString in navigator.sendBeacon" #9095

Merged
merged 1 commit into from Jan 18, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 18, 2018

This reverts commit f164b48cc02fbcb3c27cf53910818423fb11e3ae.

Reason for revert: Appears to cause usvstring-reflection.html test failures on WebKit Linux Trusty Leak, e.g.:

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/14513

04:33:47.078 30339 worker/3 external/wpt/html/dom/usvstring-reflection.html failed:
04:33:47.078 30339 worker/3 leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,18],"numberOfLivePausableObjects":[2,3],"numberOfLiveResources":[0,3]})

Original change's description:

[USVString] Change the type of url with USVString in navigator.sendBeacon

Latest spec has used USVString instead of DOMString for url argument.

This CL replaces DOMString type with USVString type according to the spec.

Bug: 790860
Change-Id: I66825c20395ea6fd6b26e32fc8f6508fd85aeef7
Reviewed-on: https://chromium-review.googlesource.com/869970
Reviewed-by: Takeshi Yoshino tyoshino@chromium.org
Commit-Queue: Gyuyoung Kim gyuyoung.kim@lge.com
Cr-Commit-Position: refs/heads/master@{#530123}

TBR=tyoshino@chromium.org,gyuyoung.kim@lge.com

Change-Id: I36a251d058756f509daa330c952546b7a1064130
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 790860
Reviewed-on: https://chromium-review.googlesource.com/874050
Reviewed-by: Stephen McGruer smcgruer@chromium.org
Commit-Queue: Stephen McGruer smcgruer@chromium.org
Cr-Commit-Position: refs/heads/master@{#530154}

Revert "[USVString] Change the type of url with USVString in navigato…
…r.sendBeacon"

This reverts commit f164b48cc02fbcb3c27cf53910818423fb11e3ae.

Reason for revert: Appears to cause usvstring-reflection.html test failures on WebKit Linux Trusty Leak, e.g.:

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/14513

04:33:47.078 30339 worker/3 external/wpt/html/dom/usvstring-reflection.html failed:
04:33:47.078 30339 worker/3  leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,18],"numberOfLivePausableObjects":[2,3],"numberOfLiveResources":[0,3]})

Original change's description:
> [USVString] Change the type of url with USVString in navigator.sendBeacon
>
> Latest spec has used USVString instead of DOMString for url argument.
>  - spec: https://w3c.github.io/beacon/#dom-navigator-sendbeacon
>
> This CL replaces DOMString type with USVString type according to the spec.
>
> Bug: 790860
> Change-Id: I66825c20395ea6fd6b26e32fc8f6508fd85aeef7
> Reviewed-on: https://chromium-review.googlesource.com/869970
> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
> Cr-Commit-Position: refs/heads/master@{#530123}

TBR=tyoshino@chromium.org,gyuyoung.kim@lge.com

Change-Id: I36a251d058756f509daa330c952546b7a1064130
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 790860
Reviewed-on: https://chromium-review.googlesource.com/874050
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530154}
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 18, 2018

Build PASSED

Started: 2018-01-18 21:45:10
Finished: 2018-01-18 21:54:45

Failing Jobs

  • MicrosoftEdge:14.14393

Unstable Results

Browser: "Microsoftedge 14.14393" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/html/dom/usvstring-reflection.html   TIMEOUT: 1
OK: 9
  anchor : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
assert_equals: expected "\ufffd" but got "?"
  area : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
assert_equals: expected "\ufffd" but got "?"
  base : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
assert_equals: expected true but got false
  document.open : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
Permission denied
  Document URLs: unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
Permission denied
  EventSource : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
'EventSource' is undefined
  frame : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
assert_equals: expected true but got false
  iframe : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
assert_equals: expected true but got false
  link : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
assert_equals: expected true but got false
  location.hash : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
assert_equals: expected "#%EF%BF%BD" but got "#?"
  location.href : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
Permission denied
  source : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
assert_equals: expected true but got false
  storage event : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
Function expected
  websocket url : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
'EventSource' is undefined
  window.open : unpaired surrogate codepoint should be replaced with U+FFFD FAIL: 9
Permission denied

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a6714ab into master Jan 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-f73ccec7a6 branch Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.