Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support calc() in media queries #9096

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 18, 2018

calc() was previously unsupported in CSS media queries. This change adds
in support for parsing calc() values in media queries, transitioning
MediaQueryExp.cpp to use CSSParserHelpers functions instead of bare
CSSParserTokens.

Bug: 421909
Change-Id: Ib4ccbdf9b21534c258610b1c8cde8be6b2c15f77
Reviewed-on: https://chromium-review.googlesource.com/866152
WPT-Export-Revision: 341187b14da214e68ca0dbed6e101f2f82302717

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 18, 2018

Build PASSED

Started: 2018-01-22 23:48:24
Finished: 2018-01-22 23:56:52

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-866152 branch from 1ceea18 to 98296f6 Jan 22, 2018

Support calc() in media queries
calc() was previously unsupported in CSS media queries. This change adds
in support for parsing calc() values in media queries, transitioning
MediaQueryExp.cpp to use CSSParserHelpers functions instead of bare
CSSParserTokens.

Bug: 421909
Change-Id: Ib4ccbdf9b21534c258610b1c8cde8be6b2c15f77

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-866152 branch from 98296f6 to 7f6f7f4 Jan 22, 2018

@csnardi

This comment has been minimized.

Copy link
Member

csnardi commented May 29, 2018

Changes landed in #9186.

@csnardi csnardi closed this May 29, 2018

@csnardi csnardi deleted the chromium-export-cl-866152 branch May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.