Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Update paint style map behaviour for invalid properties. #9100

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 19, 2018

Custom paint callbacks receive a computed style map (implemented as
FilteredComputedStylePropertyMap) that contain only properties specified
in inputProperties(). For forwards-compatiblity, inputProperties() is
allowed to have "invalid" or shorthand properties, which are not allowed
to be in the styleMap.

As resolved in [1], the style map should ignore any invalid/shorthand
properties. Furthermore, if a custom property is specified in
inputProperties(), it should have a default value of CSSUnparsedValue()
(not "null").

These changes also require changes in custom paint tests. Namely:

  • Can no longer get "border-radius" from the style map. Have to use
    a longhand property like "border-left-radius".

  • Getting custom properties like "--bar" will have a default value of
    CSSUnparsedValue.

[1] w3c/css-houdini-drafts#523

Bug: 803690
Change-Id: I148b52568de698f69ee0bf594a2b92a9751ea484
Reviewed-on: https://chromium-review.googlesource.com/874984
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: Xida Chen xidachen@chromium.org
Reviewed-by: Ian Kilpatrick ikilpatrick@chromium.org
Cr-Commit-Position: refs/heads/master@{#530763}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 19, 2018

Build PASSED

Started: 2018-01-23 04:07:12
Finished: 2018-01-23 04:12:06

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-874984 branch from 08d8a7a to 18a9a42 Jan 20, 2018

[css-typed-om] Update paint style map behaviour for invalid properties.
Custom paint callbacks receive a computed style map (implemented as
FilteredComputedStylePropertyMap) that contain only properties specified
in inputProperties(). For forwards-compatiblity, inputProperties() is
allowed to have "invalid" or shorthand properties, which are not allowed
to be in the styleMap.

As resolved in [1], the style map should ignore any invalid/shorthand
properties. Furthermore, if a custom property is specified in
inputProperties(), it should have a default value of CSSUnparsedValue()
(not "null").

These changes also require changes in custom paint tests. Namely:

- Can no longer get "border-radius" from the style map. Have to use
  a longhand property like "border-left-radius".

- Getting custom properties like "--bar" will have a default value of
  CSSUnparsedValue.

[1] w3c/css-houdini-drafts#523

Bug: 803690
Change-Id: I148b52568de698f69ee0bf594a2b92a9751ea484
Reviewed-on: https://chromium-review.googlesource.com/874984
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530763}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-874984 branch from 18a9a42 to 2ecdea8 Jan 20, 2018

@gsnedders gsnedders closed this Jan 23, 2018

@gsnedders gsnedders reopened this Jan 23, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a19b359 into master Jan 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-874984 branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.