Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sensors]Provide error codes from SensorProvider #9104

Merged
merged 1 commit into from Jan 22, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 19, 2018

Return error codes from the SensorProvider.GetSensor() method.

In future it will be used to return correct errors in
Generic Sensor API (e.g. 'NotAllowedError' if permissions
are denied).

Bug: 796894
Change-Id: I613c6f3792fde3c05142f1b4cf809655b4acb15f
Reviewed-on: https://chromium-review.googlesource.com/864325
Reviewed-by: Reilly Grant reillyg@chromium.org
Reviewed-by: Jochen Eisinger jochen@chromium.org
Reviewed-by: Alexander Shalamov alexander.shalamov@intel.com
Reviewed-by: Tom Sepez tsepez@chromium.org
Commit-Queue: Mikhail Pozdnyakov mikhail.pozdnyakov@intel.com
Cr-Commit-Position: refs/heads/master@{#530997}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

[Sensors]Provide error codes from SensorProvider
Return error codes from the SensorProvider.GetSensor() method.

In future it will be used to return correct errors in
Generic Sensor API (e.g. 'NotAllowedError' if permissions
are denied).

Bug: 796894
Change-Id: I613c6f3792fde3c05142f1b4cf809655b4acb15f
Reviewed-on: https://chromium-review.googlesource.com/864325
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Cr-Commit-Position: refs/heads/master@{#530997}
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 22, 2018

Build PASSED

Started: 2018-01-22 21:35:23
Finished: 2018-01-22 21:49:00

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ca5f14e into master Jan 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-864325 branch Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.