Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-align] The 'left' and 'right' values must be invalid in block axis #9112

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 20, 2018

The CSS WG resolved to remove the 'left' and 'right' values from the
block/cross axis alignment properties.

w3c/csswg-drafts#1403

This CL changes the CSS parsing logic of all the CSS Box Alignment
properties, both block-axis (align-{self, items, content} and
inline-axis (justify-{self, items, content}).

Additionally, the alignment shorthands (place-{self, items, content})
have been also changed to respect the new syntax.

This change also affects the Grid Layout alignment logic.

Bug: 802095
Change-Id: Id848ce22a9b2d69ecf2bfd58503f590e4b2fe4db
Reviewed-on: https://chromium-review.googlesource.com/877519
Reviewed-by: meade_(do not use) meade@chromium.org
Commit-Queue: Javier Fernandez jfernandez@igalia.com
Cr-Commit-Position: refs/heads/master@{#531074}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-877519 branch 2 times, most recently from ba5a738 to 3a980ef Jan 20, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 22, 2018

Build PASSED

Started: 2018-01-23 01:12:21
Finished: 2018-01-23 01:42:33

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:14.14393

View more information about this build on:

[css-align] The 'left' and 'right' values must be invalid in block axis
The CSS WG resolved to remove the 'left' and 'right' values from the
block/cross axis alignment properties.

w3c/csswg-drafts#1403

This CL changes the CSS parsing logic of all the CSS Box Alignment
properties, both block-axis (align-{self, items, content} and
inline-axis (justify-{self, items, content}).

Additionally, the alignment shorthands (place-{self, items, content})
have been also changed to respect the new syntax.

This change also affects the Grid Layout alignment logic.

Bug: 802095
Change-Id: Id848ce22a9b2d69ecf2bfd58503f590e4b2fe4db
Reviewed-on: https://chromium-review.googlesource.com/877519
Reviewed-by: meade_(do not use) <meade@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#531074}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-877519 branch from 3a980ef to ecdf381 Jan 23, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a4f05cb into master Jan 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-877519 branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.