Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Throw exception if serializing unsupported CSSMathValues #9116

Merged
merged 1 commit into from Jan 22, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 21, 2018

Currently, there are some CSSMathValues that can't be serialized because
we have not implemented the calc lv4 spec [1]. This patch makes toString
throw an exception if we try to serialize to a calc value that is not
yet valid in Blink.

We fix the web platform test to match the lv4 spec, but we still leave
the test as .tentative as the spec is still a draft.

[1] https://drafts.csswg.org/css-values-4/#calc-notation

Bug: 803739
Change-Id: I12253dbfcd58f0f0d8def26368e93e873ddc8323
Reviewed-on: https://chromium-review.googlesource.com/877200
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#530804}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 21, 2018

Build PASSED

Started: 2018-01-22 04:07:55
Finished: 2018-01-22 04:13:42

Failing Jobs

  • safari:11.0

View more information about this build on:

[css-typed-om] Throw exception if serializing unsupported CSSMathValues
Currently, there are some CSSMathValues that can't be serialized because
we have not implemented the calc lv4 spec [1]. This patch makes toString
throw an exception if we try to serialize to a calc value that is not
yet valid in Blink.

We fix the web platform test to match the lv4 spec, but we still leave
the test as .tentative as the spec is still a draft.

[1] https://drafts.csswg.org/css-values-4/#calc-notation

Bug: 803739
Change-Id: I12253dbfcd58f0f0d8def26368e93e873ddc8323
Reviewed-on: https://chromium-review.googlesource.com/877200
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530804}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-877200 branch from 45c2e80 to 0b4a26c Jan 22, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6aa9181 into master Jan 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-877200 branch Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.