Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-multicol] Support percentages in column-gap #9120

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 22, 2018

This patch adds percentage support to column-gap property.

Most of the changes are related to the parsing logic,
the column-gap property now accepts both length and percentages,
on top of the "normal" initial value.
A new utility class GapLength has been added, as it'll be useful
to implement row-gap in the future.

Apart from that the muticolumn layout code has been modified
to resolve the percentage gaps (treating them as zero while computing
preferred widths) and resolving them during layout.
This doesn't follow the current text on the spec, but there is an
ongoing discussion that might cause the text is changed:
w3c/csswg-drafts#509 (comment)
We could update the implementation once we have a definitive answer
from the CSS WG.

Added a new WPT test to check the behavior under different
sizing conditions.

BUG=799413
TEST=external/wpt/css/css-multicol/multicol-gap-percentage-001.html

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Icccd046e913353b6f525481046a41ad125aea5ff
Reviewed-on: https://chromium-review.googlesource.com/878199
Reviewed-by: meade_(do not use) meade@chromium.org
Reviewed-by: Darren Shen shend@chromium.org
Reviewed-by: Christian Biesinger cbiesinger@chromium.org
Reviewed-by: Morten Stenshorne mstensho@chromium.org
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Cr-Commit-Position: refs/heads/master@{#531356}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 22, 2018

Build PASSED

Started: 2018-01-23 21:47:45
Finished: 2018-01-23 21:56:05

Failing Jobs

  • MicrosoftEdge:14.14393

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-878199 branch from 2c2c268 to 5b10f0d Jan 22, 2018

[css-multicol] Support percentages in column-gap
This patch adds percentage support to column-gap property.

Most of the changes are related to the parsing logic,
the column-gap property now accepts both length and percentages,
on top of the "normal" initial value.
A new utility class GapLength has been added, as it'll be useful
to implement row-gap in the future.

Apart from that the muticolumn layout code has been modified
to resolve the percentage gaps (treating them as zero while computing
preferred widths) and resolving them during layout.
This doesn't follow the current text on the spec, but there is an
ongoing discussion that might cause the text is changed:
w3c/csswg-drafts#509 (comment)
We could update the implementation once we have a definitive answer
from the CSS WG.

Added a new WPT test to check the behavior under different
sizing conditions.

BUG=799413
TEST=external/wpt/css/css-multicol/multicol-gap-percentage-001.html

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Icccd046e913353b6f525481046a41ad125aea5ff
Reviewed-on: https://chromium-review.googlesource.com/878199
Reviewed-by: meade_(do not use) <meade@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531356}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-878199 branch from 5b10f0d to 4b5f5d9 Jan 23, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit cf8ec6b into master Jan 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-878199 branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.