Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Clean up StylePropertyMap.get tests. #9126

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 23, 2018

This patch does the following to clean up the StylePropertyMap.get
tests for WPT:

  • We split happy cases and sad cases into separate files.
  • We removed the .tentative extension.
  • Added additional tests for style map liveness.

Bug: 774887
Change-Id: I4143b6358f0d2b11fbb34be03696d5eea00bd0fa
Reviewed-on: https://chromium-review.googlesource.com/878104
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#531129}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 23, 2018

Build PASSED

Started: 2018-01-23 02:51:33
Finished: 2018-01-23 03:23:33

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:14.14393

View more information about this build on:

[css-typed-om] Clean up StylePropertyMap.get tests.
This patch does the following to clean up the StylePropertyMap.get
tests for WPT:

- We split happy cases and sad cases into separate files.
- We removed the .tentative extension.
- Added additional tests for style map liveness.

Bug: 774887
Change-Id: I4143b6358f0d2b11fbb34be03696d5eea00bd0fa
Reviewed-on: https://chromium-review.googlesource.com/878104
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531129}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-878104 branch from 908e554 to daf8e26 Jan 23, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a24f9d2 into master Jan 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-878104 branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.