Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S13nServiceWorker: Support network fallback with blob request body. #9130

Merged
merged 1 commit into from Jan 24, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 23, 2018

For subresource requests only. This makes a clone of the request body
before passing it to the service worker in ServiceWorkerSubresourceLoader.
This way if the service worker does network fallback, the request
can be passed to network with the request body intact.

Change-Id: I00c1861449e997a50c417336961a7c8c62bc710e
Bug: 778878
Reviewed-on: https://chromium-review.googlesource.com/867817
Commit-Queue: Matt Falkenhagen falken@chromium.org
Reviewed-by: Kinuko Yasuda kinuko@chromium.org
Cr-Commit-Position: refs/heads/master@{#531414}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 23, 2018

Build PASSED

Started: 2018-01-24 03:53:44
Finished: 2018-01-24 03:58:04

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-867817 branch 4 times, most recently from e9f2382 to 88f1caa Jan 23, 2018

S13nServiceWorker: Support network fallback with blob request body.
For subresource requests only. This makes a clone of the request body
before passing it to the service worker in ServiceWorkerSubresourceLoader.
This way if the service worker does network fallback, the request
can be passed to network with the request body intact.

Change-Id: I00c1861449e997a50c417336961a7c8c62bc710e
Bug: 778878
Reviewed-on: https://chromium-review.googlesource.com/867817
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531414}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-867817 branch from 88f1caa to 4845de6 Jan 24, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0e28b06 into master Jan 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-867817 branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.