Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in RTCStats-helper.js for WPT #9134

Merged
merged 1 commit into from Jan 24, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 23, 2018

Make a number of stats optional because their generation
depends on specific states; they're not always present.

Check a number of stats only if the kind is the right one.

Bug: None
Change-Id: I7f3e307b0f0f14df0f62bc2ac3a226018640f873
Reviewed-on: https://chromium-review.googlesource.com/880983
Reviewed-by: Henrik Boström hbos@chromium.org
Commit-Queue: Harald Alvestrand hta@chromium.org
Cr-Commit-Position: refs/heads/master@{#531386}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@alvestrand

This comment has been minimized.

Copy link
Contributor

alvestrand commented Jan 23, 2018

Tagging @soareschen (couldn't find you as a chromium reviewer)

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 23, 2018

Build PASSED

Started: 2018-01-24 00:22:20
Finished: 2018-01-24 00:30:50

Failing Jobs

  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/webrtc/RTCPeerConnection-getStats.https.html   TIMEOUT: 1
OK: 9
  getStats(null) should succeed PASS: 9
  getStats() on track associated with RtpReceiver should return stats report containing inbound-rtp stats FAIL: 9
assert_true: Expect statsReport to contain stats object of type inbound-rtp expected true got false
  getStats() on track associated with RtpSender should return stats report containing outbound-rtp stats FAIL: 9
promise_test: Unhandled rejection with value: object "Error: Invalid constraint"
  getStats() with connected peer connections having tracks and data channel should return all mandatory to implement stats FAIL: 9
assert_unreached: test failed with error: Error: Invalid constraint Reached unreachable code
  getStats() with no argument should return stats for no-stream tracks FAIL: 9
promise_test: Unhandled rejection with value: object "Error: Invalid constraint"
  getStats() with no argument should return stats report containing peer-connection stats and outbound-track-stats FAIL: 9
promise_test: Unhandled rejection with value: object "Error: Invalid constraint"
  getStats() with no argument should return stats report containing peer-connection stats on an empty PC FAIL: 9
assert_true: Expect statsReport to contain stats object of type peer-connection expected true got false
  getStats() with no argument should succeed PASS: 9
  getStats() with track added via addTrack should succeed FAIL: 9
promise_test: Unhandled rejection with value: object "Error: Invalid constraint"
  getStats() with track added via addTransceiver should succeed FAIL: 9
Type error
  getStats() with track associated with both sender and receiver should reject with InvalidAccessError FAIL: 9
assert_unreached: Should have rejected: undefined Reached unreachable code
  getStats() with track associated with more than one sender should reject with InvalidAccessError FAIL: 9
promise_test: Unhandled rejection with value: object "Error: Invalid constraint"
  getStats() with track not added to connection should reject with InvalidAccessError FAIL: 9
promise_test: Unhandled rejection with value: object "Error: Invalid constraint"
/webrtc/RTCPeerConnection-track-stats.https.html   TIMEOUT: 1
OK: 9
  addTrack(): Media stream stats references track stats FAIL: 9
assert_unreached: Error: Invalid constraint Reached unreachable code
  addTrack() without setLocalDescription() yields media stream stats FAIL: 9
assert_unreached: Error: Invalid constraint Reached unreachable code
  addTrack() without setLocalDescription() yields track stats FAIL: 9
assert_unreached: Error: Invalid constraint Reached unreachable code
  addTrack() with setLocalDescription() yields media stream stats FAIL: 9
assert_unreached: Error: Invalid constraint Reached unreachable code
  addTrack() with setLocalDescription() yields track stats FAIL: 9
assert_unreached: Error: Invalid constraint Reached unreachable code
  Legacy addStream(): Media stream stats references track stats FAIL: 9
assert_unreached: Error: Invalid constraint Reached unreachable code
  O/A exchange yields inbound RTP stream stats for receiving track FAIL: 9
assert_unreached: Error: Invalid constraint Reached unreachable code
  O/A exchange yields outbound RTP stream stats for sending track FAIL: 9
assert_unreached: Error: Invalid constraint Reached unreachable code
  replaceTrack() after answer: new track attachment stats present FAIL: 9
assert_unreached: Error: Invalid constraint Reached unreachable code
  replaceTrack() after offer, before answer: new track attachment stats present FAIL: 9
assert_unreached: Error: Invalid constraint Reached unreachable code
  replaceTrack() before offer: new track attachment stats present FAIL: 9
assert_unreached: Error: Invalid constraint Reached unreachable code
  replaceTrack(): original track attachment stats present after replacing FAIL: 9
assert_unreached: Error: Invalid constraint Reached unreachable code
/webrtc/RTCRtpSender-getStats.https.html   TIMEOUT: 3
OK: 7
  sender.getStats() via addTrack should return stats report containing outbound-rtp stats FAIL: 7
promise_test: Unhandled rejection with value: object "Error: Invalid constraint"
  sender.getStats() via addTransceiver should return stats report containing outbound-rtp stats FAIL: 7
sender.getStats is not a function. (In 'sender.getStats()', 'sender.getStats' is undefined)

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-880983 branch from fdd2e2b to 61014b5 Jan 23, 2018

Fix issues in RTCStats-helper.js for WPT
Make a number of stats optional because their generation
depends on specific states; they're not always present.

Check a number of stats only if the kind is the right one.

Bug: None
Change-Id: I7f3e307b0f0f14df0f62bc2ac3a226018640f873
Reviewed-on: https://chromium-review.googlesource.com/880983
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531386}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-880983 branch from 61014b5 to 78928cc Jan 24, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 4aede5c into master Jan 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-880983 branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.