Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch most preload tests to PerformanceObserver instead of a timer #9135

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@yoavweiss
Copy link
Contributor

yoavweiss commented Jan 23, 2018

Currently many preload tests are slow due to their use of a timer. PerformanceObserver enables us to avoid that in most cases, by giving us a notification when resources were downloaded, independent from their load events.
This PR switches most of the preload tests to use that method. (Failed to switch all, as we don't have a notification when resources failed to load, nor guarantees regarding PerfObserver firing with regard to the resource's load event)

@wpt-pr-bot wpt-pr-bot requested a review from snuggs Jan 23, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 23, 2018

Build ERRORED

Started: 2018-01-30 14:26:29
Finished: 2018-01-30 14:47:53

Failing Jobs

  • firefox:nightly
  • MicrosoftEdge:14.14393
  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/preload/preload-with-type.html   TIMEOUT: 1
OK: 9
  Makes sure that preloaded resources with a type attribute trigger the onload event FAIL: 9
assert_true: Preload not supported expected true got false
/preload/single-download-preload.html   TIMEOUT: 1
OK: 9
  Makes sure that preloaded resources are not downloaded again when used FAIL: 9
promise_test: Unhandled rejection with value: "Unsupported APIs"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.