Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely shutdown Firefox from in delete_session. #9140

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@jgraham
Copy link
Contributor

jgraham commented Jan 23, 2018

With the request to shutdown the browser, a given amount of time
has to be waited to allow the process to shutdown itself. Only
if the process is still running afterward it has to be killed.

Firefox has an integrated background monitor which observes
long running threads during shutdown, and kills those after
65s. To allow Firefox to shutdown on its own, geckodriver
has to wait that time, and some additional seconds.

MozReview-Commit-ID: 4LRLQE0jZzw

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1403923 [ci skip]


This change is Reviewable

Safely shutdown Firefox from in delete_session.
With the request to shutdown the browser, a given amount of time
has to be waited to allow the process to shutdown itself. Only
if the process is still running afterward it has to be killed.

Firefox has an integrated background monitor which observes
long running threads during shutdown, and kills those after
65s. To allow Firefox to shutdown on its own, geckodriver
has to wait that time, and some additional seconds.

MozReview-Commit-ID: 4LRLQE0jZzw

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1403923 [ci skip]
@jgraham

This comment has been minimized.

Copy link
Contributor Author

jgraham commented Jan 23, 2018

Code reviewed upstream.

@jgraham jgraham merged commit c190ce0 into master Jan 23, 2018

@jgraham jgraham deleted the sync_53bca18327e874eb70a12d839f9ddd8bd1427c69 branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.