Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for calc() on font-size on various situations. #9164

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
3 participants
@jgraham
Copy link
Contributor

jgraham commented Jan 23, 2018

It makes no sense to pass a custom base size of zero in presence of rem, ex, or
ch units.

MozReview-Commit-ID: 7ZZwRzQKREX

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1431031 [ci skip]


This change is Reviewable

Tests for calc() on font-size on various situations.
It makes no sense to pass a custom base size of zero in presence of rem, ex, or
ch units.

MozReview-Commit-ID: 7ZZwRzQKREX

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1431031 [ci skip]
@jgraham

This comment has been minimized.

Copy link
Contributor Author

jgraham commented Jan 23, 2018

Code reviewed upstream.

@jgraham jgraham merged commit 9dad718 into master Jan 23, 2018

@jgraham jgraham deleted the sync_e5f362229b22a1c70f7d9b10b5d32cbcc64c1509 branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.