Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce assert_time_equals_literal and use it. #9165

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
3 participants
@jgraham
Copy link
Contributor

jgraham commented Jan 23, 2018

This assertion is supposed to be used where the first argument has a tolerance
but the second argument doesn't have such tolerance. Whereas
assert_times_equal() is supposed to be used for the case both arguments have
the same tolerance, actually it hasn't, it will be fixed in a subsequent patch
in this patch series.

MozReview-Commit-ID: FEDHilbX2rm

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1430654 [ci skip]


This change is Reviewable

Introduce assert_time_equals_literal and use it.
This assertion is supposed to be used where the first argument has a tolerance
but the second argument doesn't have such tolerance.  Whereas
assert_times_equal() is supposed to be used for the case both arguments have
the same tolerance, actually it hasn't, it will be fixed in a subsequent patch
in this patch series.

MozReview-Commit-ID: FEDHilbX2rm

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1430654 [ci skip]
@jgraham

This comment has been minimized.

Copy link
Contributor Author

jgraham commented Jan 23, 2018

Code reviewed upstream.

@jgraham jgraham merged commit f9917a5 into master Jan 23, 2018

@jgraham jgraham deleted the sync_da70788987d9f8dfadad37e0144190502a669c51 branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.