Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-align] justify-content doesn't allow <baseline-position> values #9168

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 23, 2018

The CSS WG has resolved that it doesn't make sense to define Baseline
Content-Alignment in the inline/main axis.

w3c/csswg-drafts#1184

The spec has been updated so that is not valid for
the 'justify-content' property's syntax. This CL updates our parsing
logic to match the new spec, including the parsing logic of the
place-content shorthand.

Additionally, this CL updates the computed value of the
values to match other browsers.

We don't implement support for values in the
Content Distribution properties (align-content and justify-content),
so I don't expect this change to break content of sites using the CSS
Box Alignment feature.

Bug: 802248, 803275
Change-Id: I0d3b1b7e7dd28552ee7e131bfe09ef7198565283
Reviewed-on: https://chromium-review.googlesource.com/882362
Reviewed-by: Darren Shen shend@chromium.org
Commit-Queue: Javier Fernandez jfernandez@igalia.com
Cr-Commit-Position: refs/heads/master@{#532400}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 23, 2018

Build PASSED

Started: 2018-01-29 12:13:44
Finished: 2018-01-29 12:40:04

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:14.14393

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-882362 branch 3 times, most recently from b09005a to 577a6e8 Jan 24, 2018

[css-align] justify-content doesn't allow <baseline-position> values
The CSS WG has resolved that it doesn't make sense to define Baseline
Content-Alignment in the inline/main axis.

w3c/csswg-drafts#1184

The spec has been updated so that <baseline-postion> is not valid for
the 'justify-content' property's syntax. This CL updates our parsing
logic to match the new spec, including the parsing logic of the
place-content shorthand.

Additionally, this CL updates the computed value of the
<baseline-position> values to match other browsers.

We don't implement support for <baseline-position> values in the
Content Distribution properties (align-content and justify-content),
so I don't expect this change to break content of sites using the CSS
Box Alignment feature.

Bug: 802248, 803275
Change-Id: I0d3b1b7e7dd28552ee7e131bfe09ef7198565283
Reviewed-on: https://chromium-review.googlesource.com/882362
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#532400}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-882362 branch from 577a6e8 to 2f8b216 Jan 29, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit cd714f0 into master Jan 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-882362 branch Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.