Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittests failing because lint test failing #9170

Merged
merged 2 commits into from Jan 24, 2018

Conversation

Projects
None yet
4 participants
@gsnedders
Copy link
Contributor

gsnedders commented Jan 23, 2018

This change is Reviewable

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 24, 2018

Build PASSED

Started: 2018-01-24 15:35:45
Finished: 2018-01-24 15:51:48

View more information about this build on:

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Jan 24, 2018

This is failing with:

ERROR:lint:css/css-grid/alignment/support/100x100-green.png: The filename support/100x100-green.png is shared by: css/css-flexbox/support/100x100-green.png, css/css-grid/alignment/support/100x100-green.png, css/css-grid/grid-items/support/100x100-green.png (CSS-COLLIDING-SUPPORT-NAME)

This seems to be pre-existing. :(

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Jan 24, 2018

See #9172 for fixing the existing failing lint, and #9171 for the underlying cause of how we landed a test that fails the lint).

@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Jan 24, 2018

I think you missed a case.

@gsnedders gsnedders force-pushed the gsnedders:lint_breakage branch from ad66d3c to 6492b30 Jan 24, 2018

@Hexcles

This comment has been minimized.

Copy link
Member

Hexcles commented Jan 24, 2018

Sorry, late to the party, but LGTM. Thanks :)

@gsnedders gsnedders merged commit 357c23f into web-platform-tests:master Jan 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the gsnedders:lint_breakage branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.