Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Make custom paint canvas work with <gradient>s. #9174

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 24, 2018

Currently the custom paint canvas cannot draw CSSImageValues
representing s. The main difficulty is that s may
specify relative lengths / colors that need to be resolved using a
ComputedStyle.

To implement this, we create a new subclass CSSStyleGradientValue. When
a CSSStyleGradientValue is created from a custom paint styleMap, we pass
in the Node that the paint callback corresponds to. When we need to
generate an image, we use the Node to resolve any lengths / colors.

Bug: 803680
Change-Id: I15994c7b87015731547da581720f42d29384426b

Reviewed-on: https://chromium-review.googlesource.com/882906
WPT-Export-Revision: 0d4468a152ce7b42bdccb4baa8a54b756f0471ef

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 24, 2018

Build PASSED

Started: 2018-02-26 20:14:16
Finished: 2018-02-26 20:20:32

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-882906 branch from a18166e to 6697c54 Jan 30, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-882906 branch 2 times, most recently from 235fe53 to 2081fc1 Feb 20, 2018

[css-typed-om] Make custom paint canvas work with <gradient>s.
Currently the custom paint canvas cannot draw CSSImageValues
representing <gradient>s. The main difficulty is that <gradient>s may
specify relative lengths / colors that need to be resolved using a
ComputedStyle.

To implement this, we create a new subclass CSSStyleGradientValue. When
a CSSStyleGradientValue is created from a custom paint styleMap, we pass
in the Node that the paint callback corresponds to. When we need to
generate an image, we use the Node to resolve any lengths / colors.

Bug: 803680
Change-Id: I15994c7b87015731547da581720f42d29384426b

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [css-typed-om] WIP: Make custom paint canvas work with <gradient>s. [css-typed-om] Make custom paint canvas work with <gradient>s. Feb 26, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-882906 branch from 2081fc1 to 58c02cd Feb 26, 2018

@frivoal frivoal added the wg-css label Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.