Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Implement CSSNumericValue.type(). #9184

Merged
merged 1 commit into from Jan 25, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 24, 2018

This patch implements CSSNumericValue.type(), which exposes the type
of a CSSNumericValue in the form of a dictionary.

We changed a lot of tests because we originally couldn't inspect the
type of a CSSNumericValue via JavaScript, so we mainly wrote unit tests.
Now we can directly test the types in web platform tests.

WIP API:
https://github.com/w3c/css-houdini-drafts/pull/546/files

Bug: 803684
Change-Id: Ie86a81c42cab34cd01286a3066be6bc9fda50fce
Reviewed-on: https://chromium-review.googlesource.com/880422
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#531751}


This change is Reviewable

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 24, 2018

Build PASSED

Started: 2018-01-25 01:57:21
Finished: 2018-01-25 02:11:29

View more information about this build on:

[css-typed-om] Implement CSSNumericValue.type().
This patch implements CSSNumericValue.type(), which exposes the type
of a CSSNumericValue in the form of a dictionary.

We changed a lot of tests because we originally couldn't inspect the
type of a CSSNumericValue via JavaScript, so we mainly wrote unit tests.
Now we can directly test the types in web platform tests.

WIP API:
https://github.com/w3c/css-houdini-drafts/pull/546/files

Bug: 803684
Change-Id: Ie86a81c42cab34cd01286a3066be6bc9fda50fce
Reviewed-on: https://chromium-review.googlesource.com/880422
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531751}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-880422 branch from e335d00 to e20a47f Jan 25, 2018

@foolip foolip referenced this pull request Jan 25, 2018

Closed

wpt-pr-bot is down #9195

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jan 25, 2018

@wpt-pr-bot is down (#9195) so this hasn't been auto-approved. Approving myself, but not merging just to see if the wpt export bot will do the right thing. @Hexcles FYI.

@foolip

foolip approved these changes Jan 25, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7c831ba into master Jan 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-880422 branch Jan 25, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jan 25, 2018

It works!

@tobie

This comment has been minimized.

Copy link
Contributor

tobie commented Jan 25, 2018

Summoning @wpt-pr-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.