Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-layout-api] Add parsing for display: layout(foo) #9185

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 24, 2018

This adds the ability for display to accept two new functions
layout() and inline-layout().

I was careful to keep the bits for all the typical display types on the
ComputedStyleBase object, hence the display property now is a primitive
type. The name of the custom layout is defined as an extra field.

As a result of this split, (display now not just accepting a keyword)
the display property doesn't use as much auto generated code now. I.e.
EDisplay is not automatically generated.

Currently inline-layout(foo) isn't to spec, as there needs to be
separate work to change display into a two keyword longhand property.
I.e. https://drafts.csswg.org/css-display/#the-display-properties

I've filed bug: crbug.com/804600 to track this.

Bug: 726125
Change-Id: I36f6131b5c8308a97639f4813cebd3eb7ceb45ad
Reviewed-on: https://chromium-review.googlesource.com/879135
Commit-Queue: Ian Kilpatrick ikilpatrick@chromium.org
Reviewed-by: Kentaro Hara haraken@chromium.org
Reviewed-by: Rune Lillesveen futhark@chromium.org
Reviewed-by: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#532319}

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 24, 2018

Build PASSED

Started: 2018-01-29 04:24:57
Finished: 2018-01-29 04:29:50

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-879135 branch 2 times, most recently from a5e5679 to 8409aad Jan 24, 2018

@tobie

This comment has been minimized.

Copy link
Contributor

tobie commented Jan 25, 2018

Summoning @wpt-pr-bot.

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-879135 branch 5 times, most recently from 2115003 to 9ab72b6 Jan 26, 2018

[css-layout-api] Add parsing for display: layout(foo)
This adds the ability for display to accept two new functions
layout() and inline-layout().

I was careful to keep the bits for all the typical display types on the
ComputedStyleBase object, hence the display property now is a primitive
type. The name of the custom layout is defined as an extra field.

As a result of this split, (display now not just accepting a keyword)
the display property doesn't use as much auto generated code now. I.e.
EDisplay is not automatically generated.

Currently inline-layout(foo) isn't to spec, as there needs to be
separate work to change display into a two keyword longhand property.
I.e. https://drafts.csswg.org/css-display/#the-display-properties

I've filed bug: crbug.com/804600 to track this.

Bug: 726125
Change-Id: I36f6131b5c8308a97639f4813cebd3eb7ceb45ad
Reviewed-on: https://chromium-review.googlesource.com/879135
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532319}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-879135 branch from 9ab72b6 to 122c257 Jan 29, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e213f4c into master Jan 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-879135 branch Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.