Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support calc() in media queries #9186

Merged
merged 1 commit into from Jan 25, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 24, 2018

calc() was previously unsupported in CSS media queries. This change adds
in support for parsing calc() values in media queries, transitioning
MediaQueryExp.cpp to use CSSParserHelpers functions instead of bare
CSSParserTokens.

Bug: 421909
Change-Id: I81fea4dc6c70caaab79874722f114d261c26c886
Reviewed-on: https://chromium-review.googlesource.com/884571
Reviewed-by: Eric Willigers ericwilligers@chromium.org
Commit-Queue: Chris Nardi cnardi@chromium.org
Cr-Commit-Position: refs/heads/master@{#531825}


This change is Reviewable

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 24, 2018

Build PASSED

Started: 2018-01-25 06:15:55
Finished: 2018-01-25 06:19:57

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-884571 branch from d1a02ec to 3c5b6cd Jan 25, 2018

Support calc() in media queries
calc() was previously unsupported in CSS media queries. This change adds
in support for parsing calc() values in media queries, transitioning
MediaQueryExp.cpp to use CSSParserHelpers functions instead of bare
CSSParserTokens.

Bug: 421909
Change-Id: I81fea4dc6c70caaab79874722f114d261c26c886
Reviewed-on: https://chromium-review.googlesource.com/884571
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531825}
@foolip

foolip approved these changes Jan 25, 2018

Copy link
Contributor

foolip left a comment

@wpt-pr-bot is down (#9195) so this hasn't been auto-approved. Approving myself, but not merging just to see if the wpt export bot will do the right thing. @Hexcles FYI.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit edb4b84 into master Jan 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-884571 branch Jan 25, 2018

@tobie

This comment has been minimized.

Copy link
Contributor

tobie commented Jan 25, 2018

Summoning @wpt-pr-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.