Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run webvr/idlharness with a secure context #9187

Merged

Conversation

Projects
None yet
5 participants
@kearwood
Copy link
Contributor

kearwood commented Jan 24, 2018

Secure contexts will be required to expose the WebVR 1.1
interfaces (https://immersive-web.github.io/webvr/spec/1.1/)
in browsers such as Firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=1381645).

webvr/idlharness.html will fail on browsers that enforce
the secure context requirement by hiding the interfaces.

renaming idlharness.html to idlharness.https.html resolves
the issue by running in a secure context where the
interfaces are exposed.

Run webvr/idlharness with a secure context
Secure contexts will be required to expose the WebVR 1.1
interfaces (https://immersive-web.github.io/webvr/spec/1.1/)
in browsers such as Firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=1381645).

webvr/idlharness.html will fail on browsers that enforce
the secure context requirement by hiding the interfaces.

renaming idlharness.html to idlharness.https.html resolves
the issue by running in a secure context where the
interfaces are exposed.
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 25, 2018

Build PASSED

Started: 2018-01-25 01:10:20
Finished: 2018-01-25 01:22:15

View more information about this build on:

@tobie

This comment has been minimized.

Copy link
Contributor

tobie commented Jan 25, 2018

Summoning @wpt-pr-bot.

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Jan 25, 2018

No owner on this pull request has write-access to the repository. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@annevk

annevk approved these changes Jan 31, 2018

Copy link
Member

annevk left a comment

Would you please also create a test that ensures WebVR is not exposed over HTTP? That is, a negation of sorts. Unfortunately these are not autogenerated from IDL thus far.

@annevk annevk merged commit e48ecde into web-platform-tests:master Jan 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.